fix: only override gas settings in executor when set - #820
Closed
gustavogama-cll wants to merge 1 commit into
Closed
fix: only override gas settings in executor when set#820gustavogama-cll wants to merge 1 commit into
gustavogama-cll wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts EVM executor construction so gas settings from proposal metadata only override signer defaults when explicitly provided, preventing unintended GasLimit=0 (gas estimation) behavior on some chains.
Changes:
- Make
GasPriceoverride conditional ongasPricebeing present (!= nil) in EVM additional fields. - Make
GasLimitoverride conditional ongasLimitbeing non-zero in EVM additional fields. - Add inline rationale explaining why
GasLimit=0(estimation) can be problematic on certain RPCs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+79
to
+83
| auth.GasPrice = evmChainMetadata.GasPrice | ||
| } | ||
| if evmChainMetadata.GasLimit != 0 { | ||
| auth.GasLimit = evmChainMetadata.GasLimit | ||
| } |
Comment on lines
+75
to
+79
| // Only override when the proposal specifies a value; a zero GasLimit forces | ||
| // go-ethereum to estimate gas, which calls eth_getCode against the "pending" | ||
| // block and fails on chains (e.g. Avalanche Fuji) that no longer support it. | ||
| if evmChainMetadata.GasPrice != nil { | ||
| auth.GasPrice = evmChainMetadata.GasPrice |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.